Steve Kriss

Results 197 comments of Steve Kriss

Added the `help wanted` label here if anyone is interested in picking up this issue!

The way I read it, the spec is fine -- it gives implementors the option to merge compatible Listeners across Gateways, but does not imply that they must, nor that...

@sunjayBhatia if you don't have any further comments we can merge this as-is and I can do a quick follow-up on my above comment.

Oops, missed that there's a merge conflict. @izturn if you can resolve that, then we can get this in.

I'd suggest taking another look at https://github.com/chipmk/docker-mac-net-connect, I've had success using it before on macOS for this sort of thing and it doesn't require any changes for EG. I can...

:+1: to this in concept, need to review the exact placement in the API and the code though.

@izturn I think this looks good, if you can rebase I can do a final review to see if we can get into 1.23.

The other option would be to actually set the `ResolvedRefs` condition to true (rather than omitting it) when all refs can be resolved. This would be inline with upcoming Gateway...

Yeah you may have similar issues for those. I'd say clearing the existing conditions before translate is probably a good first step, but yeah ultimately we probably need more intelligent...

@izturn once you've added the requested test case, I think this is ready for merge.