contour icon indicating copy to clipboard operation
contour copied to clipboard

Published 20 hours ago • verified publisher icon projectcontour

crd/ContourDeployment: Add fields 'extraVolumes & extraVolumeMounts'

Open izturn opened this issue 3 years ago • 6 comments

add the fields extraVolumes &extraVolumeMounts to crd/ContourDeployment to let pod/envoy can mount more volumes

Signed-off-by: Gang Liu [email protected]

izturn avatar Aug 19 '22 06:08 izturn

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

github-actions[bot] avatar Sep 03 '22 00:09 github-actions[bot]

ping @skriss @tsaarni

izturn avatar Sep 05 '22 03:09 izturn

ping again @skriss @tsaarni

izturn avatar Sep 08 '22 01:09 izturn

Codecov Report

Merging #4680 (ee4baf7) into main (aa741b0) will increase coverage by 0.03%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4680      +/-   ##
==========================================
+ Coverage   76.04%   76.07%   +0.03%     
==========================================
  Files         140      140              
  Lines       16859    16878      +19     
==========================================
+ Hits        12820    12840      +20     
+ Misses       3787     3786       -1     
  Partials      252      252
Impacted Files Coverage Δ
internal/provisioner/model/model.go 92.10% <ø> (ø)
internal/provisioner/controller/gateway.go 55.43% <100.00%> (+0.32%) :arrow_up:
internal/provisioner/controller/gatewayclass.go 55.55% <100.00%> (+3.20%) :arrow_up:
...nternal/provisioner/objects/dataplane/dataplane.go 87.78% <100.00%> (+0.20%) :arrow_up:

codecov[bot] avatar Sep 09 '22 08:09 codecov[bot]

@izturn could you add some commentary on what kinds of additional things you expect users will want to mount into the Envoy pod? I don't know if we've had requests to do so before, but our basic example is just YAML so people can do as they please

sunjayBhatia avatar Sep 09 '22 15:09 sunjayBhatia

with my use case, I want to pull the envoy_access.log at the specific path, such as /tmp by elk, so adding this feature will help that

izturn avatar Sep 10 '22 00:09 izturn

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

github-actions[bot] avatar Sep 25 '22 00:09 github-actions[bot]

@izturn once you've added the requested test case, I think this is ready for merge.

skriss avatar Oct 11 '22 20:10 skriss