contour icon indicating copy to clipboard operation
contour copied to clipboard

Published 20 hours ago • verified publisher icon projectcontour

crd/ContourDeployment: Add fields for resource quotas

Open izturn opened this issue 3 years ago • 1 comments

add the fields to crd/ContourDeployment to enable resource quotas for Contour components

Signed-off-by: Gang Liu [email protected]

izturn avatar Sep 10 '22 01:09 izturn

Codecov Report

Merging #4712 (1537725) into main (b184f57) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4712      +/-   ##
==========================================
+ Coverage   76.07%   76.09%   +0.02%     
==========================================
  Files         140      140              
  Lines       16890    16895       +5     
==========================================
+ Hits        12849    12857       +8     
+ Misses       3789     3786       -3     
  Partials      252      252
Impacted Files Coverage Δ
internal/provisioner/model/model.go 92.20% <ø> (ø)
internal/provisioner/controller/gateway.go 56.69% <100.00%> (+0.46%) :arrow_up:
...nternal/provisioner/objects/dataplane/dataplane.go 87.87% <100.00%> (+0.02%) :arrow_up:
...ernal/provisioner/objects/deployment/deployment.go 91.34% <100.00%> (+0.03%) :arrow_up:
internal/sorter/sorter.go 98.97% <0.00%> (+1.53%) :arrow_up:

codecov[bot] avatar Sep 10 '22 01:09 codecov[bot]

:+1: to this in concept, need to review the exact placement in the API and the code though.

skriss avatar Sep 26 '22 20:09 skriss

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Oct 11 '22 00:10 github-actions[bot]

+1 to this in concept, need to review the exact placement in the API and the code though.

any advise? @skriss

izturn avatar Oct 14 '22 02:10 izturn

@izturn I think this looks good, if you can rebase I can do a final review to see if we can get into 1.23.

skriss avatar Oct 17 '22 17:10 skriss

@skriss PTAL

izturn avatar Oct 18 '22 02:10 izturn