contour icon indicating copy to clipboard operation
contour copied to clipboard

Published 20 hours ago • verified publisher icon projectcontour

crd/ContourDeployment: Add field 'CommonLabels"

Open izturn opened this issue 3 years ago • 2 comments

add the field CommonLabels to crd/ContourDeployment to enable add labels for Contour resources

Signed-off-by: Gang Liu [email protected]

izturn avatar Sep 09 '22 02:09 izturn

Codecov Report

Merging #4709 (8cdf4df) into main (1865338) will increase coverage by 0.00%. The diff coverage is 92.15%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4709   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         140      140           
  Lines       16762    16787   +25     
=======================================
+ Hits        12733    12753   +20     
- Misses       3778     3782    +4     
- Partials      251      252    +1
Impacted Files Coverage Δ
internal/provisioner/controller/gateway.go 55.10% <25.00%> (-0.62%) :arrow_down:
internal/provisioner/objects/secret/secret.go 46.91% <66.66%> (ø)
internal/provisioner/model/model.go 92.10% <100.00%> (+0.10%) :arrow_up:
internal/provisioner/model/names.go 100.00% <100.00%> (ø)
...provisioner/objects/contourconfig/contourconfig.go 100.00% <100.00%> (ø)
...nternal/provisioner/objects/dataplane/dataplane.go 87.58% <100.00%> (+0.17%) :arrow_up:
...ernal/provisioner/objects/deployment/deployment.go 91.30% <100.00%> (+0.23%) :arrow_up:
...ovisioner/objects/rbac/clusterrole/cluster_role.go 80.59% <100.00%> (ø)
...ts/rbac/clusterrolebinding/cluster_role_binding.go 74.50% <100.00%> (ø)
internal/provisioner/objects/rbac/role/role.go 73.58% <100.00%> (ø)
... and 5 more

codecov[bot] avatar Sep 09 '22 03:09 codecov[bot]

hey @sunjayBhatia @skriss, let's discuss moving forward #4724 from this pr?

izturn avatar Sep 19 '22 03:09 izturn

@sunjayBhatia if you don't have any further comments we can merge this as-is and I can do a quick follow-up on my above comment.

skriss avatar Sep 30 '22 16:09 skriss

@sunjayBhatia if you don't have any further comments we can merge this as-is and I can do a quick follow-up on my above comment.

yep. sounds good, just added one more comment on the existing test, but thats not actually an issue with this PR

sunjayBhatia avatar Sep 30 '22 17:09 sunjayBhatia

Oops, missed that there's a merge conflict. @izturn if you can resolve that, then we can get this in.

skriss avatar Sep 30 '22 20:09 skriss