Steve Kriss
Steve Kriss
Tentatively adding to 1.23 milestone.
Bumping to 1.24 since this is not going to be possible until Gateway API v0.6.0.
We've added this for the nightly runs of `main` conformance tests, but still blocked on running it against PRs/push builds until the next Gateway API release is out.
I'll abstain, fine with whatever others prefer.
Closing, replaced by #494
Local rate limiting could be a good simple one to spike both ways, if we had something functional that we could show it might help with an upstream discussion
@sunjayBhatia's PR to clarify this upstream has been merged: https://github.com/kubernetes-sigs/gateway-api/pull/1401 So looks like now we need to fix Contour to pass the conformance test!
Hmm yeah I'm dubious of the value of comparing headers alphabetically, hard to say that that's a logical way to order things (other than just making it deterministic), but you...
I think options 1 or 3 from your list above are reasonable. 1 is probably simplest and could be refactored into 3 down the road if needed. I think it's...
https://github.com/projectcontour/contour/actions/runs/3106117016/jobs/5032736225#step:7:290 :(