seladb
seladb
> @seladb It should be able to generate them at build time. Shouldn't be that hard to do it with pure CMake even. > > Although that way, it would...
@Dimi1010 just to make sure I understand, mostly because I'm not a CMake expert: do we want to have a CMake flag to control whether to have both the new...
> @Dimi1010 @seladb IMO it's easier to handle this on the user side based on the cmake version or PKG config version no ? @clementperon But it will make PcapPlusPlus...
This is an old PR that has a lot of conflicts with the current `dev` branch. I'll close it for now
> Looks good code wise. > > A minor issue with the timepoint params, tho. IMO, every method that takes a timepoint should be templated to allow usages of the...
@Dimi1010 can you address the remaining comments so we can merge this PR?
@JasMetzger, please notice that clang-format fails in CI
> Sorry for the delay--- I was out of town. Where is this test failing? @JasMetzger you can see the pre-commit build that failed: https://github.com/seladb/PcapPlusPlus/actions/runs/19214326473/job/54921310413?pr=2009 There are trailing white-spaces and...
> When I run the pre-commit, there are errors in files that I did not modify. Shall I address those? @JasMetzger there shouldn't be errors in files you did not...
@JasMetzger should we move this PR to DRAFT until it's ready for review? The CI is currently failing...