seladb
Add decoding and encoding of `UTCTime` and `GeneralizedTime` ASN.1 records
Codecov Report
Attention: Patch coverage is 99.15014% with 3 lines in your changes missing coverage. Please review.
Project coverage is 83.12%. Comparing base (
644e4ff) to head (7406f05). Report is 1 commits behind head on dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| Packet++/src/Asn1Codec.cpp | 98.20% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## dev #1837 +/- ##
==========================================
+ Coverage 83.00% 83.12% +0.12%
==========================================
Files 285 285
Lines 49258 49611 +353
Branches 10475 10482 +7
==========================================
+ Hits 40886 41239 +353
- Misses 7240 7241 +1
+ Partials 1132 1131 -1
| Flag | Coverage Δ | |
|---|---|---|
| alpine320 | 75.34% <98.92%> (+0.24%) |
:arrow_up: |
| fedora42 | 75.45% <98.92%> (+0.27%) |
:arrow_up: |
| macos-13 | 80.63% <96.39%> (+0.12%) |
:arrow_up: |
| macos-14 | 80.63% <96.39%> (+0.12%) |
:arrow_up: |
| macos-15 | 80.61% <96.39%> (+0.12%) |
:arrow_up: |
| mingw32 | 71.53% <95.34%> (+0.20%) |
:arrow_up: |
| mingw64 | 71.52% <95.34%> (+0.20%) |
:arrow_up: |
| npcap | 85.05% <98.63%> (+0.09%) |
:arrow_up: |
| rhel94 | 75.24% <98.92%> (+0.24%) |
:arrow_up: |
| ubuntu2004 | 59.01% <96.71%> (+0.32%) |
:arrow_up: |
| ubuntu2004-zstd | 59.12% <96.71%> (+0.32%) |
:arrow_up: |
| ubuntu2204 | 75.14% <98.92%> (+0.22%) |
:arrow_up: |
| ubuntu2204-icpx | 61.44% <60.00%> (-0.02%) |
:arrow_down: |
| ubuntu2404 | 75.37% <98.92%> (+0.22%) |
:arrow_up: |
| ubuntu2404-arm64 | 75.35% <98.92%> (+0.24%) |
:arrow_up: |
| unittest | 83.12% <99.15%> (+0.12%) |
:arrow_up: |
| windows-2019 | 85.08% <98.63%> (+0.09%) |
:arrow_up: |
| windows-2022 | 85.09% <98.63%> (+0.09%) |
:arrow_up: |
| winpcap | 85.22% <98.63%> (+0.09%) |
:arrow_up: |
| xdp | 51.12% <98.92%> (+0.46%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks good code wise.
A minor issue with the timepoint params, tho. IMO, every method that takes a timepoint should be templated to allow usages of the dirrerent clocks provided by the standard via a SFINAE template as the current implementation requires usage of system clock timepoints. High res and steady clock timepoints can't be used there. This is fine for now, but we might want a to-do or issue open for that.
Sure, maybe we can address it later as needed