seladb
seladb
Can you provide the full command that failed?
@clementperon thanks for your work, it looks great! The best way to verify that all platforms work is to add CMake to the CI. Would you consider doing that?
@clementperon thanks for working on this! In the CI it looks like the Windows builds don't use CMake yet, is this still WIP?
Regarding Windows - there is some kind of an issue with `zstd` - @egecetin also saw it in [his PR](https://github.com/seladb/PcapPlusPlus/pull/775). I'll check and keep you posted. Ideally we should replace...
> @seladb I have no experience to support windows compilation but as it compile with Make if shouldn't be hard to support it with cMake. > > I think we...
> Todo: > > * Android support. > > * Shared libs > > * generate a PcapPlusPlusConfig.cmake We should also make sure Visual Studio works...
Woohoo 🎉 Regarding moving to c++11 - it's a bigger change because it's a breaking change. We need to discuss when to do it. Do you think we can decouple...
I think that if we move to cmake we can remove the current build system. Maintaining both will be harder. BTW, much like moving to c++11, this is also a...
> So introducing Cmake will drop Ubuntu 16.04 ? I think it's not that bad regarding that Ubuntu 22.04 is planned 3 months. Yes, I think it makes sense. Ununtu...
@clementperon as a general note I wanted to thank you for working on all these enhancements, I really appreciate your work and it's a great contribution to this project. BIG...