Results 544 comments of seladb

Thanks @ponyatov ! We'll look into it. If you have a fix in mind, you're more than welcome to open a PR! 🙏

@ponyatov I tried a similar configuration and it works for me. Maybe you should remove `/include` from `-DDPDK_INCLUDE_DIRS`? ``` > cmake -DBUILD_SHARED_LIBS=OFF -DPCAPPP_BUILD_PCAPPP=ON -DPCAPPP_USE_DPDK=ON -DDPDK_ROOT=/home/seladb/dpdk-stable-24.11.1 -DDPDK_DEBUG=YES -DDPDK_INCLUDE_DIRS=/home/seladb/dpdk-stable-24.11.1 -S . -B...

You'll see this error when `rte_pktmbuf_alloc` returns `nullptr` which probably indicates that the mempool used to allocate packets is empty. What's the mempool size you're using in `initDpdk()`?

@ponyatov it looks like you're pre-allocating enough mbufs, but still the system runs out of mbufs... are you sure the hugepages size is enough for these mbufs? Also - there...

> [@seladb](https://github.com/seladb) While looking for this issue, I went through this function in SSLHandshake.cpp > > ``` > SSLx509Certificate* SSLCertificateMessage::getCertificate(int index) const > { > if (index < 0 ||...

@egecetin this PR contains a lot of changes and is hard to review. Is it possible to maybe split it into multiple smaller PRs? Maybe: - Run clang-format for different...

> Most of them clang-format change so I can split clang-format Maybe at least split clang-format from the rest so it's easier to review?

> Pushed an update. Feedback is appreciated! @Marti2203 CI fails, can you please take a look?

@Marti2203 @danasana [This PR](https://github.com/seladb/PcapPlusPlus/pull/1954) should also cover this fix, am I wrong?

> > @Marti2203 @danasana [This PR](https://github.com/seladb/PcapPlusPlus/pull/1954) should also cover this fix, am I wrong? > > @seladb Yes, I believe so. I have tested the problematic scenario on my PR,...