seladb

> @seladb @Dimi1010 I've started adding some tests, but I have a question regarding the ".dat" files; how can I generate examples for some Modbus frames? If you open the...

@yahyayozo CI fails, can you please look into it? 🙁

> @seladb Hi, can you please check the progress I've reached until now? please leave comments on any part that needs adjustement @yahyayozo sure, I'm sorry for the long delay....

> @seladb pcap files are ignored, in the gitignore, how can I commit my modbus.pcap file? @yahyayozo you can use `git add -f modbus.pcap` to force adding a pcap file...

@yahyayozo please scroll up and see all the comments that weren't addressed

@yahyayozo the tests fail in CI...

@yahyayozo please also see older comments: - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2265164208 - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2278509145 - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2287041041 - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2287041757 - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2278514017

@yahyayozo I think the only comments left are: - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2278509145 - https://github.com/seladb/PcapPlusPlus/pull/1823#discussion_r2278514017 Once you address those I think we can merge this PR

@yahyayozo thank you so much for working on this and contributing to PcapPlusPlus, it is much appreciated! 🙏

@FlashBarryAllen in order to review this PR I'd like to know the protocol better. I did some reading and here is what I found. Can you please confirm these are...