seladb

> [@seladb](https://github.com/seladb) > > I discovered that DPDK unit tests also fail on a 16-core machine. I've opened a new issue. Once we pass all unit tests on systems with...

@xiaofei-1024 can you provide a pcap file that contains padding and FCS that we can look at?

@xiaofei-1024 can you attach a pcap file to this issue?

@Dimi1010 I'm not sure why replacing 2 protected members (`m_Packet`, `m_IsAllocatedInPacket`) with 1 private struct (`m_AllocationInfo`) that contains both of them improves anything... if we want to avoid using protected...

> @seladb It mitigates the risk of this issue [#2004 (comment)](https://github.com/seladb/PcapPlusPlus/pull/2004#discussion_r2462149580) which was a bug that can be hard to track and easy to happen and completely broke the memory...

> It wouldn't have been that simple to find. I found it only after I grouped the variables and a test suddenly started memory leaking due to being incorrect. It...

I remember I had these thoughts when I created `MBufRawPacket`, but I'm not sure creating an interface or a base class is really needed. `MBufRawPacket` overrides the necessary functions of...

Since we only have 2 classes `RawPacket` and `MBufRawPacket` and most of the code uses `RawPacket`, I don't think it'd be very hard to maintain both. If we add more...

I don't disagree with your claims, I just think it'd be a lot of work that is not really needed and might create additional bugs in a sensitive part of...

> Hi @seladb, did you have a chance to look at it yet? @fdw I'm sorry, I probably missed it somehow, thanks for checking in! I'll take a look in...