Rishabh Shukla
Rishabh Shukla
Would really love to be part of this Campaign :smile:
I've claimed #1098 :smiley:
Opened PR #1634 for issues #1033 and #1040
Opened PR #1625 for issues #1098 #147 #1030
Hey @jywarren I've added the advanced features for colorbar module, if you want some other addition to this then please do tell :smile:
@publiclab/is-reviewers please review this!
Instead of doing this, we can do it in the Module.js itself like we do in Crop or Overlay, that would be much cleaner! https://github.com/publiclab/image-sequencer/blob/7c63bb53a47c0a620ac1768f27484f59f012a319/src/modules/Overlay/Module.js#L70-L75
I could help out in maintaining modules and core functionalities, while working on #1564 I had to go through a lot of code related to these
Yea @HarshKhandeparkar goals and pririties looks good to me, we can continue with this :)
What happened when you compared the base64 string of two images instead of comparing it with looks-same? Were the tests still passing?