Rishabh Shukla

Results 69 comments of Rishabh Shukla

@HarshKhandeparkar The error was because the syntax for taking input in CLI was ``` ./index.js -s "webgl-distort" -c '{"nw":"100,100","se":"40,40"}' -i examples/images/test.png ``` So I rewrote how the inputs were taken...

@publiclab/is-reviewers what do you all think?

@publiclab/is-reviewers @jywarren @HarshKhandeparkar please review this :)

@publiclab/is-reviewers please review this

> I think the old code has non-descriptive variables and is, well, old. Can we at least make the new additions better if not change the old code? I think...

@publiclab/is-reviewers please review this

@tech4GT @jywarren please review this Also could you suggest some other name for this module, I am really bad at this :sweat_smile:

>But there's an issue here, we can't just crop in one step and then overlay in another, coz once you export the image you'll get the black borders again. Since...

@tech4GT I am getting this as cli output. ![image_1](https://user-images.githubusercontent.com/42492389/73595239-5125af80-453c-11ea-9ff7-97bf0405be21.png) These were the inputs ![Screenshot from 2020-02-01 21-48-24](https://user-images.githubusercontent.com/42492389/73595268-ac57a200-453c-11ea-9ecc-a52db75b9bab.png)

@tech4GT I've also added the functionality to crop the image so that the quadilateral lies in smallest possible rectangle so we don't have to compute for the extra pixels. ![Screenshot...