Rishabh Shukla

Results 69 comments of Rishabh Shukla

@jywarren could you please take a look at this!

> Wow this is epic! Uh, i guess I'd like to get reviews from others too - and, it looks like tests are failing, no? Thank you! Tests are failing...

Only Canvas-Resize is failing as of now(and that too because I changed a bit how its implemented and added a new feature [link](https://github.com/publiclab/image-sequencer/pull/1564#issuecomment-577889025) so that only needs a benchmark update)...

@jywarren everything is fixed now :tada: :smile:

@jywarren can we get this merged soon so as to avoid any merge conflicts as this changes a lot of files!

@HarshKhandeparkar It is rebased review it again. @jywarren can we get this merge soon as this solves a really big bug, thanks!

Hi @jywarren @HarshKhandeparkar I was a bit busy with university, I'll fix the PR ASAP, ty :)

@HarshKhandeparkar tests for edge detect are failing for some reason do you have any idea?

@HarshKhandeparkar What I am getting: ![1](https://user-images.githubusercontent.com/42492389/99498554-aaf94800-299d-11eb-813b-6f7332db49fd.png) What is expected: ![2](https://user-images.githubusercontent.com/42492389/99498556-acc30b80-299d-11eb-8c48-27c4e7469a2a.png) Should I just update the benchmark?

@publiclab/is-reviewers @jywarren please review this!