image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Copy decoded qr

Open ataata107 opened this issue 5 years ago • 6 comments

Fixes #1471 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! ezgif com-video-to-gif (8)

  • [X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • [X] code is in uniquely-named feature branch and has no merge conflicts
  • [X] PR is descriptively titled
  • [X] ask @publiclab/is-reviewers for help, in a comment below
  • [X] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

ataata107 avatar Jan 14 '20 01:01 ataata107

@publiclab/is-reviewers

ataata107 avatar Jan 14 '20 01:01 ataata107

Codecov Report

Merging #1491 into main will increase coverage by 9.74%. The diff coverage is 61.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
+ Coverage   55.11%   64.86%   +9.74%     
==========================================
  Files         117      133      +16     
  Lines        2344     2769     +425     
  Branches      360      442      +82     
==========================================
+ Hits         1292     1796     +504     
+ Misses       1052      973      -79     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 10.42% <3.84%> (-1.77%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 102 more

codecov[bot] avatar Jan 14 '20 01:01 codecov[bot]

@HarshKhandeparkar sorry for being late. Done

ataata107 avatar Jan 21 '20 18:01 ataata107

Instead of doing this, we can do it in the Module.js itself like we do in Crop or Overlay, that would be much cleaner! https://github.com/publiclab/image-sequencer/blob/7c63bb53a47c0a620ac1768f27484f59f012a319/src/modules/Overlay/Module.js#L70-L75

rishabhshuklax avatar Jan 21 '20 18:01 rishabhshuklax

There can be other modules which can have string output. Hence I only did it in defaultHtmlStepUi.js instead of changing module.js for all such cases

ataata107 avatar Jan 21 '20 19:01 ataata107

gitpod-io[bot] avatar Jul 08 '20 05:07 gitpod-io[bot]