image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

"Bug Stomp February" - A Bug Fixing Marathon

Open harshkhandeparkar opened this issue 5 years ago • 14 comments

Why

It seems that ImageSequencer has a lot of bugs and optimization issues. For example, it does not work on Firefox https://github.com/publiclab/image-sequencer/issues/1211.

We trying to add awesome features like Face Detection and Motion Blur. Just look at the contributions below. Screenshot from 2020-02-12 22-55-45 This is superb! This is the sign of a bustling community.

But there is one problem with this. The bugs. There are 72 open PRs out of which, a major portion is facing Travis failure. And it is during the debugging of these, that we find new bugs which are a result of old, unmaintained and unprotected (untested) code. Have a look at https://github.com/publiclab/image-sequencer/issues/1623 for example. Such issues should have been fixed a long while ago.

If we continue adding new features without fixing old bugs, we are going to face a huge roadblock where the new features will be hindered by old bugs and the features would introduce more bugs. We are just going deeper and deeper into a black hole. We need to act fast. We have to fix these bugs before we cross the event horizon, the point of no return! I am overdramatizing this but this is pretty serious.

The Campaign

This February, let's take a break from our usual issues, new feature implementation and completion of old PRs. Let's just step away from our existing PRs and start fixing bugs! Let us all claim at least one issue marked as a bug and get it fixed by the end of February. Even if you don't know how to proceed, just claim it. Do some research. I am sure you will find a solution. If your PR gets merged early, you could even claim a new one and stomp it too!

You could help us by reporting bugs too!

What You Will Learn

Debugging is something you learn only by experience. In the process of fixing a bug, you can learn a lot. You may learn to use a new feature of some programming language. You may start understanding a difficult concept better. Even quirky behaviors of obscure features will start making sense.

Let us all fix at least one bug by the end of February and maintain a list of the bugs we have "stomped". At the end of this campaign, the first week of March, we are going to have a week-long testing campaign wherein everyone adds a test to ImageSequencer to secure it from future bugs. The bugs fixed during this campaign will be linked to a test in the upcoming March campaign.

Open PRs

  1. #1625 by @blurry-x-face
  2. #1634 by @blurry-x-face

List of Stomped Bugs

  1. #1576 in #1629
  2. #1632 in #1696

NOTE: We will try not to focus on/merge PRs other than bug fixes this month.


Thank You!

cc @jywarren @publiclab/is-reviewers

harshkhandeparkar avatar Feb 12 '20 17:02 harshkhandeparkar

Let us know the bug that you have claimed in the comments of this thread, below :arrow_down:.

harshkhandeparkar avatar Feb 12 '20 17:02 harshkhandeparkar

Would really love to be part of this Campaign :smile:

rishabhshuklax avatar Feb 12 '20 17:02 rishabhshuklax

I am in for this

ataata107 avatar Feb 12 '20 17:02 ataata107

Always in for this

niravasher avatar Feb 12 '20 18:02 niravasher

I've claimed #1098 :smiley:

rishabhshuklax avatar Feb 12 '20 18:02 rishabhshuklax

Hey guys! Please try to claim an issue by the end of this week so that you have at least a week to work on it and we have a week to review it. Also mention about it here.

Thank you!

harshkhandeparkar avatar Feb 13 '20 11:02 harshkhandeparkar

I will complete #1468 and #1470 as soon as #1571 is merged. I have already opened prs for both the issues but will complete them and try to get them merged.

ataata107 avatar Feb 14 '20 09:02 ataata107

I'll be working on https://github.com/publiclab/image-sequencer/issues/1576 for Bug Stomp February!

harshkhandeparkar avatar Feb 15 '20 14:02 harshkhandeparkar

PR Opened! #1629

harshkhandeparkar avatar Feb 15 '20 15:02 harshkhandeparkar

Hi everyone! If you have claimed or are planning to fix a bug, please mark the issue (and PR) with the label "Bug Stomp February" so that we can keep track of everything and possibly archive it.

harshkhandeparkar avatar Feb 16 '20 11:02 harshkhandeparkar

Opened PR #1634 for issues #1033 and #1040

rishabhshuklax avatar Feb 21 '20 10:02 rishabhshuklax

Opened PR #1625 for issues #1098 #147 #1030

rishabhshuklax avatar Feb 21 '20 10:02 rishabhshuklax

Hi all! Getting plugged in again here! I don't have as many hours per week as before but will focus on reviewing and merging these first! Then, will fix a bug myself!!!! Thanks everyone!!! 🎉🎉🎉🎉

jywarren avatar Mar 03 '20 22:03 jywarren