Rishabh Shukla

Results 69 comments of Rishabh Shukla

Firela: https://resume.github.io/?Firela

This PR is work in progress, At the moment Resize, Crop & Constrained Crop module doesn't work correctly unless used with a setTimeout to generateOutput, This PR solves problem of...

I removed all the instances of setTimeout and added changePixel method to the modules, this makes them work without a problem, but I don't know why this is happening, for...

Ok, so i changed pixelManipulation such that generateOutput will be called only once and extraManipulation will be called only after changePixel. But, as of now resize and crop modules are...

At the moment these modules are not working - ~~canvas-resize (this is also not working on beta site)~~ - ~~colorbar(will be fixed when crop module is fixed)~~ - constrained-crop(will be...

Canvas Resize is now fixed :tada: and I've also added an option to change the background color of the new canvas :smile: ![Screenshot from 2020-01-24 03-06-02](https://user-images.githubusercontent.com/42492389/73026073-c4e9fd00-3e56-11ea-8fe8-1c949938566f.png)

Crop Module is also fixed :tada: ![Screenshot from 2020-01-24 06-34-10](https://user-images.githubusercontent.com/42492389/73037056-8f9fd800-3e73-11ea-819a-757f653973e8.png) So, since crop is fixed hence colorbar is also fixed there is minor change to be made in constrained crop...

AddQr test was failing because it's benchmark was wrong, probably changed in #1550, I've updated it, It should pass now!

All modules are working fine now :tada:

@publiclab/is-reviewers @jywarren @HarshKhandeparkar please review this!!