ordian

Results 154 comments of ordian

Hey, thanks for the PR! 1. There's an open discussion whether we want it here: #640 2. If the answer to 1 is "yes", we don't need to introduce "impl-borsh",...

As you've noticed, `Address` is a type alias for `H160`, which is a type constructed by the `fixed-hash` crate. This crate was written in the pre-const times, where the amount...

Hey, sorry for the delay in reply. Take a look at https://github.com/paritytech/parity-common/blob/854e68bb5af1bf285445228c47d1a1090e1f1bf3/primitive-types/src/lib.rs#L153-L160 Hope that helps.

This initial impl predates the stabilization of `TryFrom` trait and should be replaced by that (breaking change) indeed nowadays.

> Also disable validators who repeatedly vote against valid. That's tracked in paritytech/polkadot-sdk#785 and is purely runtime changes. > How quickly do we disable? We can disable as soon as...

> I think a better way of doing this would be to embed the shuffling algorithm into the runtime and expose a runtime API for retrieving the mapping. What part...

Is it correct that the 0.1 release is blocked on the currently open PRs (#36, #38, #40, #42)? Would be nice to have a roadmap for the initial release. cc...

> should I add a compile test to the CI to make sure future changes compile under that rocksdb flag? yes, please do you think we should also expose this...

A few things I noticed are not backwards compatible: ```toml # doesn't work: [[relaychain.node_groups]] count = 2 # workaround: [[relaychain.nodes]] name = "node-0" [[relaychain.nodes]] name = "node-1" # doesn't work...