polkadot icon indicating copy to clipboard operation
polkadot copied to clipboard

runtime: past session slashing runtime API

Open ordian opened this issue 2 years ago • 1 comments

Closes #6559. Closes #6560. Closes #6561.

Implements these methods for Rococo/Versi. Although there's no slashing there due to no staking pallet.

cumulus companion: https://github.com/paritytech/cumulus/pull/2160

ordian avatar Feb 03 '23 13:02 ordian

I don't see this part from #6560:

The caller of this API will need to pass the relay_parent of the candidate when CandidateIncluded event was emitted. This way we can guarantee that the session_index of that relay_parent is the one we need for the key ownership proof. Consideration: note that session_index from the parachains perspective and from sesssion(/historical) can differ. Make sure we're not making an off-by-one error on session boundaries when calculating the key ownership proof.

Yes, it's part of https://github.com/paritytech/polkadot/issues/5947. I've decided to separate runtime from client changes. Will submit a separate PR on top of this one.

ordian avatar Feb 05 '23 13:02 ordian

bot merge

ordian avatar May 26 '23 09:05 ordian