ordian

Results 154 comments of ordian

bot bench $ runtime kusama runtime_parachains::disputes::slashing

AFAIK, we never got this test work properly with 20k nominators. It would be nice for someone to pick this up before we merge enable slashing on kusama (@tdimitrov maybe)?...

That might be not necessary after https://github.com/paritytech/substrate/pull/12420, but still something nice to test.

Looking at the #12017, my understanding of it is to change the log level to a warn if the benchmark is slow and `--validator` flag is passed, not enable hw...

Looks good to me in effect, but I'll let the substrate team judge whether moving the types to sysinfo is OK. Thanks!

@paritytech/ci @paritytech/release-engineering @chevdor an approval please :pray: @eskimor a review please :pray: :pray: :pray:

Yes, enabling it is easy though: we need to implement v5 of ParachainHost and do the runtime upgrade: https://github.com/paritytech/polkadot/blob/cf0ecddcda542733b28597e2fc2ab2202afc3554/runtime/westend/src/lib.rs#L1477 https://github.com/paritytech/polkadot/blob/cf0ecddcda542733b28597e2fc2ab2202afc3554/runtime/kusama/src/lib.rs#L1720

Ouch, I think I tested it before #6885 was merged, but yeah, the only trouble is we will get a different type of error in debug logs. These requirements need...

> I don't see this part from #6560: > > > The caller of this API will need to pass the relay_parent of the candidate when `CandidateIncluded` event was emitted....