ordian

Results 154 comments of ordian

Actually, I think it's possible to manually implement these traits instead of deriving them.

interesting, thank you for digging into this, I believe this is due to how we use https://github.com/Vurich/crunchy/ unrolling maybe it's time to rewrite uint using generic arrays

Hey @marmistrz. Could you clarify what you need this for exactly? > it's the most convienient format to use while tracing what kind of tracing are you doing? I'm hesitant...

> This is not a breaking change: the trait implementation will only be used if the feature is enabled. I meant that when `valuable` version bumps to 0.2, updating fixed-hash...

We should probably deprecate `max_value` instead as it's deprecated in std: https://doc.rust-lang.org/std/primitive.u64.html#method.max_value.

Hey @pmarangone, the ideal way to resolve this would be to: 1. Figure out which clippy warnings are legitimate and fix them in uint. (medium) 2. Put an ignoring attribute...

I think most of our usages of ethereum-types also pull in ethbloom, so it was done intentionally. That being said, I don't mind merging this breaking change.

this is fixed only in cargo nightly: https://github.com/rust-lang/cargo/issues/8832