ordian

Results 154 comments of ordian

> FWIW it does feel that even if it's a breaking change, should be a simple one to resolve. I wish it was easy, but unfortunately it's not (e.g. #623)....

Take a look at https://doc.rust-lang.org/nightly/cargo/reference/features.html#dependency-features It will be `impl-codec?/std` instead of `impl-codec/std`. Which means enable `std` feature of `impl-codec` but only if `impl-codec` is also enabled.

Thanks for raising the issue! > I was wondering if this is on purpose or if you'd accept patches to the rlp library to raise errors appropriately? I'd need to...

Although I should note, that we use some of the invalid RLPs for compression purposes (although it might be unrelated to the issue): https://github.com/openethereum/openethereum/blob/3ccfe735aa579f89a1f8de192a7625084a6f530f/util/rlp-compress/src/common.rs

You mean something like #255?

Maybe we can have something like this https://github.com/paritytech/parity-scale-codec/pull/40?

> I don't really see the point of making stupid bounds on all generic arguments. This is a long-standing issue in rustc https://github.com/rust-lang/rust/issues/26925 that will hopefully be resolved with chalk,...

they do in primitive-types https://github.com/paritytech/parity-common/blob/2d571df7fee92b85b47b49cf14aa3a7641f2f3b9/primitive-types/src/lib.rs#L146-L252 anything missing?

`U64` is kind of legacy, see https://github.com/paritytech/parity-common/pull/473 but we can probably add conversions from it in `ethereum-types`

hey @That3Percent this code generates a type ```rust #[derive(PartialEq, Eq, Hash)] pub struct U4096(pub [u64; 64]); ... ``` The problem is that rust implements these traits (`Hash`, `Eq`, etc) only...