ordian

Results 154 comments of ordian

Why do we want to ignore double votes btw? A validator doesn't win anything by double voting AFAIK.

> While doing partitioning double votes are ignored for the reason above (fn partition_recent_disputes). This is only about if we consider the dispute as 'can conclude onchain' or not. My...

We have `from_dec_str` and `from_str_radix` methods for parsing non-hexadecimal strings. By default, it's assumed to be hexadecimal. Would you expect `let num: U256 = "aa".parse().unwrap();` to fail to parse and...

That might be a better default, however, I don't know how many crates depend on the current behavior and it won't be checked at compile time. So I'm very hesitant...

Hey @ivanceras. If there's enough demand for it, we might consider adding this feature. However, that would mean tying any major releases to a breaking change to ethereum-types, which we'd...

`uint` doesn't implement `BitOrAssign`, but implements `BitOr` trait, meaning you can do ```rust a = a | b ``` `BitOrAssign` (as well as `BitAndAssign` and `BitXorAssign`) would be easy to...

It's possible to create it like ```rust const THE_ANSWER: U256 = U256([42, 0, 0, 0]); ``` however, I agree a convenient method would be good.

I'm going to close this issue since light client mode was removed from substrate and smoldot doesn't use either kvdb or indexeddb.

https://github.com/camshaft/bolero also looks interesting as a unification interface across fuzz engines.

Hmm, this is interesting solution to #475, but ultimately, we want https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#weak-dependency-features feature, which is going to be stabilized in rust 1.60 (coming soon: https://www.whatrustisit.com/). That being said, I'm open...