Adam Scott

Results 116 comments of Adam Scott

I updated the branch. Replaced `RBSet` with `Vector`. Added a `Vector checked_script_classes` as @anvilfolk suggested.

@trollodel Didn't know that there was an existing PR about the same issue. I searched the issue tracker before starting, didn't think about searching the pull requests too. Sorry.

> Does this supersedes #57510? I would say yes. I just tested your PR and it doesn't pass, unfortunately, my added unit test.

Updated the PR to use lists instead of vectors

> I was worried that this was was doing base&outer class recursion for `check_instance_and_class_members()`, but nope! Smart PR author is smart! Everything checks out still!! I'm doing things that I...

Removed all the `GDScriptCache` additions to create instead PR #69865.

@akien-mga The PR doesn't build because I split off the code that made this PR build to #69865. Once #69865 merged, it should fix the current sanitizers issues.

Citing [CONTRIBUTING.md](https://github.com/godotengine/godot/blob/e032152494646da7933fbef13d2914c67b09ce9a/CONTRIBUTING.md#reporting-bugs) > On the contributors' end, recreating a test project from scratch takes valuable time that can be saved by uploading a _minimal_ project. > To speed up our...

Citing [CONTRIBUTING.md](https://github.com/godotengine/godot/blob/e032152494646da7933fbef13d2914c67b09ce9a/CONTRIBUTING.md#reporting-bugs) > On the contributors' end, recreating a test project from scratch takes valuable time that can be saved by uploading a _minimal_ project. > To speed up our...

Citing [CONTRIBUTING.md](https://github.com/godotengine/godot/blob/e032152494646da7933fbef13d2914c67b09ce9a/CONTRIBUTING.md#reporting-bugs) > On the contributors' end, recreating a test project from scratch takes valuable time that can be saved by uploading a _minimal_ project. > To speed up our...