Adam Scott
Adam Scott
This seems to be a duplicate of #1199
Talking of ExpressionCondition, I just implemented one in my branch. It uses params, but the expression itself is in the condition. I'll create a new branch for a quick PR,...
> Cool! I always wanted to support complex condition. Your solution is really interesting, I suppose contents of the group act like AND while groups itself act like OR. >...
Mmm. I'll think about it! It could simplify stuff, sure. Like, you're right, everything done with condition groups are done with expression conditions. But at the cost of readability. As...
Well, I'm not talking about nuking the ExpressionCondition, haha.  But I understand your point. For now, it appears to be a good solution to only merge...
I made some progress. https://github.com/adamscott/gd-YAFSM/tree/port-4.0 There's still issues still, like duplicating states, but it does not crash and burn. For now. A master build is needed as some breaking changes...
> It works by extracting parameter names from expression with the help of regex. I'm not in favor of this commit. This could bring bugs and this reduce the potential...
I modified my ExpressionCondition to set the variable instance as the base instance of the expression, with `trigger(trigger_name)` and `t(trigger_name)` functions. `t()` is just a shorthand for `trigger()`. And it...
I modified the visual of the ExpressionCondition to indicate the script nature of the condition without the need of an icon.  The expression wraps too in...
> Trigger or any other parameters are nothing but a string to look up from Dictionary. Yes and no. Trigger are the culprit here. They are specifically distinct as the...