Adam Scott

Superseded by #50

I suspect that the same `GDScriptInstance::~GDScriptInstance()` is ran twice. Try adding a `destructing` variable, like I did in `GDScript::~GDScript()`.

This patch makes the build pass the sanitizer. ```patch diff --git a/modules/gdscript/gdscript.cpp b/modules/gdscript/gdscript.cpp index 72d5bb23c5..dc87560fdd 100644 --- a/modules/gdscript/gdscript.cpp +++ b/modules/gdscript/gdscript.cpp @@ -1925,10 +1925,14 @@ GDScriptInstance::~GDScriptInstance() { while (SelfList *E =...

Weird. My local build pass the clang test sanitizers.

My hunch says that this is more sane than casting AND it should fix the macos `SIGSEGV`. ```diff diff --git a/modules/gdscript/gdscript.cpp b/modules/gdscript/gdscript.cpp index df57749f76..fc3d42b1b0 100644 --- a/modules/gdscript/gdscript.cpp +++ b/modules/gdscript/gdscript.cpp @@...

As the PR needs a rebase and the release is close, I moved the milestone to 4.2. I put it, though, in the list of PRs that needs a review...

I would put this dialog inside the editor settings, as a simple entry. I don't feel it needs to have a new menu entry.

@vnen I would push this issue to 4.x or 4.1

Hi there @ajreckof, my friend! [I made a PR](https://github.com/godotengine/godot/pull/95806) not knowing about yours. I saw your code and it seems very complicated compared to my version. I don't know why...

Is this ready?