oui icon indicating copy to clipboard operation
oui copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

Avoid using `important` in style sheets

Open kavilla opened this issue 2 years ago • 2 comments

https://uxengineer.com/css-specificity-avoid-important-css/

If there are situations where it is conflicting then we should consider fixing conflicts.

Origin: https://github.com/opensearch-project/oui/pull/131/

kavilla avatar Feb 21 '23 20:02 kavilla

Currently present in 73! files. I think this is something we can work on incrementally, as there is some risk to attempting to fix these.

joshuarrrr avatar Jun 01 '23 00:06 joshuarrrr

Currently present in 73! files. I think this is something we can work on incrementally, as there is some risk to attempting to fix these.

Completely agree. I think it would probably be possible to break these down into smaller issues.

Additionally, I think it would be nice to understand why important is used. For example, when I was working on breadcrumbs, I needed to use it to override the color of links to a custom color, which otherwise wouldn't be possible.

BSFishy avatar Sep 20 '23 19:09 BSFishy