oui icon indicating copy to clipboard operation
oui copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

Replace `sass-lint` with `stylelint`

Open gulderov opened this issue 2 years ago • 3 comments

Description

sass-lint is an unmaintained project

Please review the migration to stylelint. Which includes the following steps:

  • Avoid manual changes
  • The style check script has been changed to yarn lint-style
  • yarn lint-style --fix was run to auto fix everything possible

Issues Resolved

resolves #119

Check List

  • [x] New functionality includes testing.
  • [x] New functionality has been documented.
  • [x] All tests pass
    • [x] yarn lint
    • [x] yarn test-unit
  • [x] Update CHANGELOG.md
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

gulderov avatar Aug 03 '23 14:08 gulderov

https://github.com/opensearch-project/oui/actions/runs/5759821731/job/15628275259?pr=949#step:5:13

Do you know why the linter is failing in CI? Does it need to be rerun?

BSFishy avatar Aug 05 '23 16:08 BSFishy

@BSFishy I removed the quotes to try and fix CI

gulderov avatar Aug 08 '23 08:08 gulderov

Love to see the CI is passing, gives me a lot more confidence in this. Will re-review and approve if everything looks good

BSFishy avatar Sep 14 '23 16:09 BSFishy