oui

oui copied to clipboard

Description

Allow to portale BottomBar to any referenced DOM element

Issues Resolved

https://github.com/opensearch-project/oui/issues/707

Check List

• [x] New functionality includes testing.
• [ ] New functionality has been documented.
• [x] All tests pass
  • [x] yarn lint
  • [x] yarn test-unit
• [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BSFishy Are you happy with where this landed?

@BSFishy Are you happy with where this landed?

My concern with this PR is that it was meant to go into Dashboards but I believe it's breaking. @SergeyMyssak can confirm if that's the case. I spun up a Dashboards instance with this change and went to Stack Management and changed some settings to see the bottom bar, and nothing seemed to have broken, but if there's a chance that someone will break because of this, I don't want to put it into the 1.x line.

@BSFishy Are you happy with where this landed?

My concern with this PR is that it was meant to go into Dashboards but I believe it's breaking. @SergeyMyssak can confirm if that's the case. I spun up a Dashboards instance with this change and went to Stack Management and changed some settings to see the bottom bar, and nothing seemed to have broken, but if there's a chance that someone will break because of this, I don't want to put it into the 1.x line.

In the Dashboards, we have BottomBar in 3 places:

1. advanced_settings
2. data_source_management (create_data_source_wizard)
3. data_source_management (edit_data_source_wizard)

The changes only concern the default values usePortal and affordForDisplacement. If we merge this PR, we will need to open a PR in Dashboards in which we will need to explicitly specify the usePortal prop in items 2 and 3, because it will have no default value. No change is required for item 1. If this is a blocker for merge in 1.x, better leave it for 2.0.