Ikhun Um

Results 364 comments of Ikhun Um

@freevie Thanks so much for your hard work! ❤️🙇‍♂️

If it is repeatedly used, we may provide an option to automatically enable it such as `GrpcService.enableReflectionService(boolean)`. I am not 100% sure that it makes sense to enable it by...

> But I wonder why status is given as parameter for .asJson(MyError.class, HttpStatus.INTERNAL_SERVER_ERROR). The response format between a normal response and an error response may be different in most cases....

For gentle error messages, we can internally create `HttpStatusPredicate`. ```java class HttpStatusPredicate extends Predicate { // Use the following fields to generate error messages @Nullable private HttpStatus status; @Nullable private...

We can implement `HttpStatusPredicate` like the following. ```java final class HttpStatusPredicate extends Predicate { @Nullable private HttpStatus status; @Nullable private HttpStatusClass statusClass; ... @Override boolean test(HttpStatus status) { if (this.status...

Another problem is that the encoded path(`/abc/1%202/def`) is not updated to `RequestHeaders.path()`. The following example was reported by @kezhenxu94. https://line-armeria.slack.com/archives/C1NGPBUH2/p1629466435104000?thread_ts=1629462093.100100&cid=C1NGPBUH2 ``` mkdir -p p1/p2/p3 touch p1/p2/p3/"hello world" python3 -m http.server...

There is an encoding mismatch on the server-side. https://github.com/line/armeria/blob/5b384fbe27e7e6f9225d6db91cbb684d09dfbb5e/core/src/test/java/com/linecorp/armeria/client/HttpClientIntegrationTest.java#L319-L325 It should decode percent encoding in both `ServiceRequestContext.path()` and `HttpRequest.headers().path()`

`GrpcSerializationFormats` is added to support framed gRPC protocols. So we should think about a solution without considering `GrpcSerializationFormats`. > since there is no standard, there's no point adding headers to...

> May I try the fix? @dinujoh Are you going to fix the bug yourself? Otherwise, please let us know so @j-min5u can handle this issue. 😉