Ikhun Um
Ikhun Um
First of all, thank you for your interest in this issue. 🙇‍♂️ > I am not sure we can ever fully support comments same way as regular tokens is that...
> It seems trivial to also add support for yaml as well. I'm on the same page.
I found that `DeserializationFeature.FAIL_ON_TRAILING_TOKENS` throws an exception on valid JSON if `@JsonDeserialize` is applied to an element of a list. https://github.com/line/centraldogma/blob/3f7cac9e4543fd504b91da2d1734d3e4a49c98e3/server/src/main/java/com/linecorp/centraldogma/server/CentralDogmaConfig.java#L278-L280 ``` Trailing token (of type END_ARRAY) found after value...
> Do you have any more information when this might fail? I haven't looked at this in detail yet. Some flaky tests aren't hard to reproduce in the local environment....
> if users are not interested in the server request or client response (fire-and-forget pattern) From what I understand, Armeria requires users to consume all `HttpResponse`s to avoid memory leaks.
The masking API was added recently and is still under active development by @jrhee17, so it may not be suitable for external contributors at this time.
Generalizing `GracefulShutdown` sounds a good idea. In addition, it would also be great if `toException()` could be applied to the client's pending requests. Currently, when a `ClientFactory` is closed, all...
Thanks for your interest. However, I've already implemented `OutlierDetectingEndointGroup` internally and plan to publish it after redesigning its public API.
I agree with the overall direction.
> If an user doesn’t explicitly call responseTimeoutForEachAttempt(), RetryConfig should respect whatever value is configured in responseTimeout, not to use [Flags.defaultResponseTimeoutMillis()](https://github.com/line/armeria/blob/armeria-1.33.2/core/src/main/java/com/linecorp/armeria/client/retry/RetryConfigBuilder.java?rgh-link-date=2025-09-03T03%3A17%3A41.000Z#L38) by default That is intentional but I agree with...