Ikhun Um

Results 364 comments of Ikhun Um

`hasInterestedFlags(flags, RequestLogProperty.REQUEST_LENGTH)` must be the same with `RequestLog.isAvailable(RequestLogProperty.REQUEST_LENGTH)`. By the way, `flags` is a volatile value. So it is bad to access it repeatedly. How about adding an API that...

> this chance to see if we can make use of resilience4j. That is a nice idea.

For sure! Thanks for your attention to this.

@AmosDoan might be interested in this issue. 😆

It was originally requested in https://line-armeria.slack.com/archives/C1NGPBUH2/p1577719334033400

@antongocode You might want to see https://github.com/line/armeria-examples/blob/master/proxy-server/src/main/java/example/armeria/proxy/ProxyService.java

First of all, thank you for your interest in this issue. 🙇‍♂️ > I am not sure we can ever fully support comments same way as regular tokens is that...

> You could design/define your own gRPC service to expose other services at runtime that does not depend on Server interface. A.k.a., a simple version of ProtoReflectionService We don't really...

> Note that it is also possible to do that just for the reflection service via an interceptor. As you said, I implemented an intercepter that injects a dummy server...