Ikhun Um

> but i believe armeria grpc server has another implementation grpc server/ client ? Armeria provides its own gRPC server and client implementations so Opentelemetry's gRPC Instrumentation can not understand...

Unfortunately, I don't know the exact point and the reproducible case of this leak. It happened in the WebFlux integration module. We have fixed various leaks with some cases though....

Found another leak report while testing the WebFlux module. https://github.com/line/armeria/runs/4843457763?check_suite_focus=true#step:6:2835 ```

> I'd like to check if this implementation corresponds to your thinking of the implementation. Look through the PR quickly and I think we are on the same page. I...

It would be better to write headers as a JSON object for `LogFormatter.ofJson()`. I am not sure but, personally, I prefer to take a function that returns `JsonNode` for JSON...

Overall it is a useful feature. That being said, as an error of a client request is propagated via the returned `HttpResponse`, I prefer to add `shouldLogUncaughtException` only to `ServiceRequestContext`.

In addition to assertion, it would be useful to support mocking for isolated unit tests. Related work: https://sttp.softwaremill.com/en/latest/testing.html ```scala val testingBackend = SttpBackendStub.synchronous .whenRequestMatches(_.uri.path.startsWith(List("a", "b"))) .thenRespond("Hello there!") .whenRequestMatches(_.method == Method.POST)...

Hi,we use English for GitHub communication. If you want to ask questions in Korean, please use our Slack channel. We have two sub-channels for Korean and Japanese in https://armeria.dev/s/slack

Good point. We need more options for the orders to resolve the conflict. It seems that we can't prioritize an annotated `ResponseConverterFunction` always. - If the class type of an...

Let's say we have the following annotated service: ```kt class MyService { @ProduceJson fun flowProtobufJson(...): Flow { ... } } Server.buider() .annotatedService() .responseConverters(MyProtobufResponseConverter()) .build(MyService()) ``` We need two 2 response...