armeria icon indicating copy to clipboard operation
armeria copied to clipboard

Add the gRPC tutorial

Open freevie opened this issue 3 years ago • 5 comments

The content is truly incomplete and will be updated through reviews & QnA.

Motivation:

Add a new tutorial set for gRPC

Modifications:

  • Add tutorial draft

Result:

  • WIP

freevie avatar Dec 13 '21 12:12 freevie

I've labelled questions with "// TW question". Please have a look and let me know. Sorry, I wasn't able to compose the tutorial for the client. (Haven't checked if the code was prepared or not.) I'll get in touch with you this week.

freevie avatar Dec 13 '21 12:12 freevie

Codecov Report

Merging #3987 (d255bb7) into master (7741676) will increase coverage by 0.26%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3987      +/-   ##
============================================
+ Coverage     73.53%   73.80%   +0.26%     
- Complexity    17644    17712      +68     
============================================
  Files          1500     1509       +9     
  Lines         65990    66198     +208     
  Branches       8325     8313      -12     
============================================
+ Hits          48528    48857     +329     
- Misses        13254    13341      +87     
+ Partials       4208     4000     -208     
Impacted Files Coverage Δ
...ria/internal/common/grpc/GrpcExchangeTypeUtil.java 50.00% <0.00%> (-40.00%) :arrow_down:
.../armeria/server/grpc/UnframedGrpcErrorHandler.java 66.66% <0.00%> (-23.17%) :arrow_down:
...server/grpc/UnframedGrpcStatusMappingFunction.java 77.77% <0.00%> (-22.23%) :arrow_down:
...com/linecorp/armeria/common/metric/MoreMeters.java 78.75% <0.00%> (-8.75%) :arrow_down:
...rnal/common/GracefulConnectionShutdownHandler.java 68.08% <0.00%> (-6.39%) :arrow_down:
...eria/internal/common/stream/StreamMessageUtil.java 61.11% <0.00%> (-5.56%) :arrow_down:
...p/armeria/common/stream/AbstractStreamMessage.java 79.20% <0.00%> (-3.97%) :arrow_down:
...necorp/armeria/common/util/CompositeException.java 40.00% <0.00%> (-3.81%) :arrow_down:
...va/com/linecorp/armeria/server/docs/FieldInfo.java 60.52% <0.00%> (-3.37%) :arrow_down:
...com/linecorp/armeria/client/DefaultRestClient.java 50.00% <0.00%> (-3.34%) :arrow_down:
... and 262 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Dec 13 '21 13:12 codecov[bot]

@ikhoon , As I shared earlier, I've modified the create and read pieces. Could you check if I am going on the right direction? With your confirmation, I'll proceed with the rest of the operations.

freevie avatar Feb 23 '22 11:02 freevie

@ikhoon,

Please have a look and let me know if I got the direction and the content right.

P.S. You saved my life the other day. That local history feature is a charm! Thank you!

freevie avatar May 04 '22 13:05 freevie

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 29 '22 08:07 CLAassistant

@minwoox ,

Sorry, I didn't quite catch what you meant by this:

I guess we need this in Try writing blog service yourself.

The section titled "Try writing blog service yourself" contains a link to the "Defining a blog service and messages", so am a bit confused.

freevie avatar Aug 11 '22 08:08 freevie

Sorry, I didn't quite catch what you meant by https://github.com/line/armeria/pull/3987#discussion_r942033190: I guess we need this in Try writing blog service yourself. The section titled "Try writing blog service yourself" contains a link to the "Defining a blog service and messages", so am a bit confused.

Ah, I left my opinion on @jrhee17's comment about google/protobuf-gradle-plugin. 😄 https://github.com/line/armeria/pull/3987#discussion_r932028001

minwoox avatar Aug 11 '22 08:08 minwoox

LGTM once @jrhee17's comments are addressed. Thank you so much for writing this awesome tutorial. 🙇‍♂️ 🙇‍♂️ 🙇‍♂️

minwoox avatar Aug 23 '22 03:08 minwoox

@minwoox , @ikhoon , @jrhee17 , I believe I've applied all the comments. Please kindly let me know if I've left any out.

freevie avatar Aug 30 '22 12:08 freevie

@freevie Thanks so much for your hard work! ❤️🙇‍♂️

ikhoon avatar Sep 07 '22 04:09 ikhoon