Ikhun Um

Results 191 issues of Ikhun Um

Motivation: `HttpRequest.aggregate()` and `HttpResonse.aggregate()` allows to call only once because `StreamMessage` can be subscribed once. It seems acceptable if they can store the aggregated request or response to somewhere. It...

new feature
breaking change

``` java.lang.IllegalStateException: Failed to load ApplicationContext at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:132) at org.springframework.test.context.support.DefaultTestContext.getApplicationContext(DefaultTestContext.java:124) at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.injectDependencies(DependencyInjectionTestExecutionListener.java:118) at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.prepareTestInstance(DependencyInjectionTestExecutionListener.java:83) at org.springframework.boot.test.autoconfigure.SpringBootDependencyInjectionTestExecutionListener.prepareTestInstance(SpringBootDependencyInjectionTestExecutionListener.java:43) at org.springframework.test.context.TestContextManager.prepareTestInstance(TestContextManager.java:248) at org.springframework.test.context.junit.jupiter.SpringExtension.postProcessTestInstance(SpringExtension.java:138) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeTestInstancePostProcessors$10(ClassBasedTestDescriptor.java:377) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.executeAndMaskThrowable(ClassBasedTestDescriptor.java:382) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeTestInstancePostProcessors$11(ClassBasedTestDescriptor.java:377) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)...

cleanup

Motivation: A `@RequestObject` bean can be converted as a specification of an annotated service. Neither response nor POJO request are shown in a `DocService`. Only gRPC and Thrift `DocService` can...

new feature

Users can only specify to run a service on a blocking executor using `GrpcServiceBuilder.useBlockingTaskExecutor(true)`. https://github.com/line/armeria/blob/603e2fb23b7227c4117b5b8d7377314152f9feb4/grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcServiceBuilder.java#L678 If `@Blocking` annotation is supported for gRPC services or methods: https://github.com/line/armeria/blob/8bfe0be035ad0f2d01a6ac5ebeae465ee0a552e1/core/src/main/java/com/linecorp/armeria/server/annotation/Blocking.java#L33 - Users can easily...

new feature

`WebClient` or `RestClient` is able to deserialize a JSON response into an object using: ``` WebClient client = WebClient.of(...); ComletableFuture response = client.prepare() .get("/api/items/...") .asJson(MyItems.class) .execute(); ``` The client tries...

new feature
good first issue

Motivation: Gradle offers [Version catalog plugin](https://docs.gradle.org/current/userguide/platforms.html#sec:version-catalog-plugin) which offers to publish a catalog externally. It should be useful for many Armeria ecosystems and users' projects to align the dependencies of Armeria....

new feature

It should be helpful to assert a response to a test request fluently. ```java @RegisterExtension static ServerExtension server = ...; @Test void testRestApi() { WebTestClient client = server.webTestClient(); client.get("/api/v1/carts") .execute()...

new feature

``` ServerTlsHandshakeMetricsTest > handshakeSuccess(SessionProtocol, String, String) > com.linecorp.armeria.server.ServerTlsHandshakeMetricsTest.handshakeSuccess(SessionProtocol, String, String)[3] FAILED org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a com.linecorp.armeria.server.ServerTlsHandshakeMetricsTest Expected size: 1 but was: 2 in: [io.micrometer.prometheus.PrometheusCounter@3caa7cfb, io.micrometer.prometheus.PrometheusCounter@39d0a9a4] within 10 seconds....

cleanup

https://github.com/line/armeria/runs/3683191870?check_suite_focus=true ``` 13:51:57.304 [armeria-common-worker-epoll-2-7] ERROR io.netty.util.ResourceLeakDetector - LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at: io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:402) io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187) io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178) io.netty.buffer.AbstractByteBufAllocator.buffer(AbstractByteBufAllocator.java:115) org.springframework.core.io.buffer.NettyDataBufferFactory.allocateBuffer(NettyDataBufferFactory.java:71)...

defect