armeria icon indicating copy to clipboard operation
armeria copied to clipboard

rpc metrics in opentelemetry not populating for armeria grpc server/ client

Open gurudatta-carbon opened this issue 2 years ago • 2 comments

Armeria Opentelemetry Instrumentation: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/v1.15.0/instrumentation/armeria-1.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/v1_3

Grpc Opentelemetry Instrumentation https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/v1.15.0/instrumentation/grpc-1.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/grpc/v1_6/GrpcServerBuilderInstrumentation.java#L28

Here they expect to implement io.grpc.ServerBuilder, but i believe armeria grpc server has another implementation grpc server/ client ?

Expected Behavior Rpc Client & Server Metrics to be populated as per https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/rpc.md

gurudatta-carbon avatar Jul 12 '22 14:07 gurudatta-carbon

but i believe armeria grpc server has another implementation grpc server/ client ?

Armeria provides its own gRPC server and client implementations so Opentelemetry's gRPC Instrumentation can not understand Armeria's gRPC services. But we strongly desire to support RPC metrics for Armeria's gRPC and Thrift services.

ikhoon avatar Jul 13 '22 02:07 ikhoon

We are observing the same issue. While we were able to get the default metrics with Netty generated grpc stub, we aren't able to get the same metrics published by default after moving to Armeria generated grpc stub.

cagdas-carbon avatar Sep 02 '22 16:09 cagdas-carbon