igooch

Results 71 comments of igooch

@KAllan357 as an Unreal contributor, could you please review? This PR in particular is marked as breaking.

@KiaArmani @DevChagrins @oniku2929 as recent Unreal contributors, could you please take a look at this PR?

@tvandijck and @KiaArmani as the most recent contributors to the Unreal SDK, would you review this PR?

> Any updates? It would be great to have it in 1.43 :) 1.43 release is getting cut in a few hours, so it's probably too close for this release....

@kaboing what's the current status on this PR?

@GloryOfNight given that it looks like you use Unreal would you be able to validate the changes in this PR?

We'll wait until after the release tomorrow to merge.

I pulled down your PR and installed on a cluster. It doesn't look like the code is working as intended. ``` me@me:~/agones/build$ curl -H "Content-Type: application/json" -X GET http://localhost:${AGONES_SDK_HTTP_PORT}/v1beta1/lists/players {"name":"players","capacity":"10","values":["player1","player2","player3"]}...

The seeing two `Players` keys for Status and Spec is bizarre -- `Lists` is a map, so the keys should be unique. The Spec spec should always remain the same...