agones icon indicating copy to clipboard operation
agones copied to clipboard
verified publisher icon googleforgames

Unreal SDK - Added counters to unreal sdk

Open GloryOfNight opened this issue 1 year ago • 14 comments

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking /kind bug /kind cleanup /kind documentation

/kind feature

/kind hotfix /kind release

What this PR does / Why we need it: Added counters to unreal sdk

Which issue(s) this PR fixes: n/a

Closes #3648 (partially)

Special notes for your reviewer:

Validity of http requests not tested. Build log as requested in CONTRIBUTING.md:

buildWin64Editor.log

GloryOfNight avatar Aug 08 '24 20:08 GloryOfNight

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 08 '24 20:08 google-cla[bot]

Build Succeeded :partying_face:

Build Id: 01fbce8a-8930-430b-845b-454f9acc8cb4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://d8e45eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-d8e45eb

agones-bot avatar Aug 08 '24 22:08 agones-bot

buildWin64Editor.log

GloryOfNight avatar Aug 09 '24 09:08 GloryOfNight

Build Failed :sob:

Build Id: b480c9f0-481a-4ef5-aaf5-b76e25478735

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Aug 09 '24 09:08 agones-bot

Build Succeeded :partying_face:

Build Id: 13a8808e-11a7-4104-9cfe-db4a4cbbce36

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://c6ec608-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-c6ec608

agones-bot avatar Aug 13 '24 22:08 agones-bot

Build Succeeded :partying_face:

Build Id: 74231d6b-3a0a-49cc-b5b1-12f866cbbd87

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://98b4524-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-98b4524

agones-bot avatar Aug 20 '24 12:08 agones-bot

@tvandijck and @KiaArmani as the most recent contributors to the Unreal SDK, would you review this PR?

igooch avatar Aug 20 '24 22:08 igooch

Any updates? It would be great to have it in 1.43 :)

zifter avatar Aug 26 '24 19:08 zifter

Build Succeeded :partying_face:

Build Id: 54dafa02-7d35-4c2e-b255-65007ec87795

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://bdd95e1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-bdd95e1

agones-bot avatar Aug 26 '24 21:08 agones-bot

Any updates? It would be great to have it in 1.43 :)

1.43 release is getting cut in a few hours, so it's probably too close for this release.

@zifter or @KAllan357 would you be able to test and validate the changes in this PR?

igooch avatar Aug 26 '24 22:08 igooch

@igooch I'm working with @GloryOfNight in the same company and these changes are made by my request.

I actually can confirm, that it's tested, because we are using those changes currently in production.

zifter avatar Aug 26 '24 23:08 zifter

We only using counter decrement. Get/Set Counter is not tested. I'll give some time to test them to be sure.

GloryOfNight avatar Aug 27 '24 11:08 GloryOfNight

Tested, found issue with GetCounters() call related to default initialized content string as braces. Fixed it. Everything looks good now.

GloryOfNight avatar Aug 27 '24 12:08 GloryOfNight

Build Succeeded :partying_face:

Build Id: 9c33eb73-b894-4fca-8c1c-d50494d4ff84

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://b8b37c8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b8b37c8

agones-bot avatar Aug 27 '24 13:08 agones-bot

Build Succeeded :partying_face:

Build Id: 9e937153-a4eb-4f57-900c-c909794b5c77

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://25ac6d3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-25ac6d3

agones-bot avatar Sep 03 '24 19:09 agones-bot

Any updates?

zifter avatar Sep 06 '24 08:09 zifter

Build Succeeded :partying_face:

Build Id: a435d9bc-db09-4eb1-9577-ff4e14b46998

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://c5fa1c9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-c5fa1c9

agones-bot avatar Sep 06 '24 18:09 agones-bot