Ian
Ian
Several things: * What connections does this PR (move the location picker to the styleguide) have with the ticket (additional locations not loading in Chrome-based browsers)? * I don't think...
@jayasanka-sack So, I'm on-board with a component for viewing locations. I'm less keen on the _data-fetching_ part living in the styleguide. That is, I think the fetching should be handled...
And, yeah, for the e2e tests in core, we also need to run the `build` step.
@jayasanka-sack The ultimate issue, AFAICT, with E2E tests and framework changes is that on the Docker image, we rely on the latest published version of the app-shell (basically [this stuff](https://github.com/openmrs/openmrs-esm-core/blob/08fe1eab4e7a67fedca9947e1d15f50df48cde2d/e2e/support/github/Dockerfile#L11))....
Yeah, that's also a factor there... I mean, for a PR, though, the image will never be updated until the PR is merged.
This actually depends on openmrs/openmrs-module-webservices.rest#595, which is the active version of that PR.
This looks ok. Instead of manually rendering a toast (which ends up with a slightly weird UX, use the framework's `showToast()` method. Also, ideally, the loading indicator would disappear. Instead...
> Should we just show a subtitle instead of the reload button with something along the lines of Please contact your administrator @ibacher? Maybe have a subtitle that says "If...
> Would clicking the Reload button just invoke window.location.reload() or would it do something else? Presumably we could just call the mutator for SWR rather than doing a full page...
> Isn't the fallback for no locations is to Login without a location? I think that was what was originally implemented just to get something in. Most of the code...