Ian

Ultimately, the goal of the ticket is to replace [this function](https://github.com/openmrs/openmrs-esm-patient-management/blob/1461160f4bb1f1b24b9270868077f8e47b2d4ff0/packages/esm-patient-registration-app/src/offline.resources.ts#L128) and the places that it's used so that it only makes a single request instead of a request per...

@jwnasambu Can you take a look at the failing test? It appears the user is no longer redirected correctly? You can find the playwright output here: https://github.com/openmrs/openmrs-esm-patient-management/actions/runs/8977383799?pr=1122

Yeah, I think the ticket description is correct. I wrote it while tracing the code involved, so no filtering is probably the right move.

@denniskigen It should just be a request to `/ws/rest/v1/idgen/identifiersource`, nothing else. One thing that makes this a little tricky is that in the RefApp there is only a single identifier...

@denniskigen I just created another. You're right that multiple `&identifierType=` parameters are ignored and it just gets the first.

@usamaidrsk We should be using a [Dropdown](https://react.carbondesignsystem.com/?path=/docs/components-dropdown--overview) here which has a skeleton state to indicate that it's loading.

I see. I'd probably opt for a loading indicator inside the combo box on its right edge.

I _think_ this should work as-is with the new icon system... They are just React.Components at the end of the day.

> do you think we should just close this and do this in core straight away Might as well. I think a component like this is a sensible thing to...

We can definitely get better coverage on this package.