Ian

Results 222 comments of Ian

@sherrif10 The test error looks a bit weird. But let me give you some pointers on this PR instead. We don't want to change the support OpenMRS version. This could...

I'm pretty sure that making things work is going to require not just deleting code but moving things from the 1.8 submodule to the 1.9 submodule.

@gitcliff Can you add a test showing that sending a POST to the `TaskActionController2_4` with the payload: ``` { "action": "runtask", "tasks": [" + getTaskUuid() + "] } ``` runs...

@dkayiwa That's actually a good point... It's actually [this locale part](https://github.com/openmrs/openmrs-core/blob/6e5a44642663152d2460024f56615691791d5264/web/src/main/java/org/openmrs/web/filter/initialization/InitializationFilter.java#L204) in the `InitializationFilter`

@dkayiwa Well, for me it was happening every time I started up the 3.x RefApp Docker images. I assume it would apply to any case using Tomcat 8.5?

I suppose it may be that the [5s rate here](https://github.com/openmrs/openmrs-distro-referenceapplication/blob/698d3c4621a8163ee56c0aa9da5377327bcbccbd/docker-compose.yml#L42) is too fast...

@HerbertYiga The three things I'd like to see for this ticket are: 1. Undoing the reformatting of the Javadoc 2. The logic change I just suggested 3. A unit test...

@kdaud They're still there. They've just moved to lines [668](https://github.com/kdaud/openmrs-core/blob/8db47aad4c28db1e7ff68c2f9733670fc03ec3ea/api/src/main/java/org/openmrs/api/context/Context.java#L668) and [678](https://github.com/kdaud/openmrs-core/blob/8db47aad4c28db1e7ff68c2f9733670fc03ec3ea/api/src/main/java/org/openmrs/api/context/Context.java#L678). The first comment is a bit unfortunate because I think it directed you to the wrong place. With...

> My sense is that our AOP-based validation is misguided and we should just move all validation into service methods where appropriate. I very much agree with this. Honestly, I...

I'm happy with having a way of opting out of validation... it certainly is the less drastic change 😄.