Ian
Ian
Code looks fine. Could we make the "optional" part of this something controllable via the config system?
@mogoodrich Well, I mostly meant that since the default value is `showPatientHeader = true`, so the existing uses of this will automatically add the header. Basically, I think it would...
> What problem is this addressing, or what improvement would this allow? So it's aimed at addressing of few things: 1. The shared SWR cache is not actually de-duplicating things...
Alright, I'm now happy this works as intended, albeit it's pretty minimally functional. The only current difference between this and a global store is that the value should only ever...
@vasharma05 Rename `useLocations()` to `useLoginLocations()` and I'm happy.
Alright, my impression is the e2e test failures here are unavoidable because of how the Docker image used here is constructed. That's because this PR introduces several new components into...
@denniskigen Huh! I anticipated the shrinking in the apps themselves, since we no longer depend on `@carbon/react/icons` and because `@carbon/react/icons` is packaged in such a way that it doesn't really...
> Should it be straightforward to test locally? You're seeing exactly what you should be seeing. All the icon files are current just that placeholder image. I reverted things back...
I made some slight adjustments to this to try to reduce the chance of mistakenly importing the various SVGs, e.g., in Jest tests. This entailed some minor updates to the...
TBH, if we integrate it with a check for "is the backend starting up", I think it'd be useful and still very straight-forward.