Ian
Ian
@HerbertYiga Sorry, I just ran across this again. Is there a reason for not using the equivalent `java.time` API here? E.g., ```java // In the class private static final DateTimeFormatter[]...
@jnsereko I wouldn't worry about the security failures. They're most likely not related to your code changes (I can't see what they are). A couple of things to bear in...
@HerbertYiga You did a rebase on `master` rather than the `TRUNK-4954` branch, which gives Git permission to rewrite the root commit of this branch. Essentially, if you complete that rebase,...
If you do want to squash just the relevant commits, run `git rebase -i HEAD~3` (3 comes from the fact that there are three commits on this branch).
@HerbertYiga So the overall code for that if statement should be something like this: ```java if (obs.getPerson() != null && obs.getPerson().getIsPatient() && obs.getEncounter() != null && obs.getEncounter().getPatient() != null) {...
Hmmmm... and the stack overflow error doesn't occur when the `obs.getPerson().getIsPatient()` call is absent?
> i run into a stack over flow error @HerbertYiga So, I tried checking out this branch and then applying my suggested code above and I don't get the stack...
It'd be great to have some tests for this.
@tendomart Hopefully it's pretty straight-forward to create `handle...()` methods modelled on those from Obs or elsewhere in the code base.
@tendomart Sorry... I somehow missed the above question. The "c" and "cd" above are really just aliases for tables inside the criteria query. Just like in SQL you could write...