Ian
Ian
@suubi-joshua I think that it's preferable that this all gets wrapped up into the "assemble" command. I don't not want to add more steps that implementers need to run, just...
Also, it's better to allow users to specify files rather than directories. We can always make `--config-file configs/*` work, but we cannot make `--config-file my-config.json --config-file my-config-2.json` work.
Similarly, the output file name shouldn't be required to be specified, but have a sane default.
I'm going to close this as superceded. Sorry @suubi-joshua! Didn't mean to ignore your work.
Couple of quick comments: * `(chore)` should only be used for things that _do not touch any code used in production or tests_, things like docs, eslint configuration, tsconfig, all...
Because we use dynamic remotes, I haven’t had much experience with this exact issue, but I think it has something to do with the Webpack public path which should be...
Thanks for your contribution! I hope this doesn't come across as too harsh, but part of the reason for code reviews is to make sure that we're merging code that...
At a minimum this needs to properly build. Currently it's failing typescript. I also don't understand how you went from my previous comment to an implementation that loads the patient...
If you're adding _tests_ for something, your changes should rarely touch anything other than test code other than to make necessary adjustments to make things testable. This PR is doing...
This fundamentally subverts what this test is actually testing s this isn't really a great solution to the problem...