Ian

Results 222 comments of Ian

Is there any reason we can't more this kind of thing to core? I don't like the idea of tightly-coupling this stuff to the patient chart. If we need it...

> I don't love the tight coupling of frontend apps either We've been kind of overloading the primary-navigation-app with stuff like this, but maybe core-clinical-workspaces-app or something? For future use...

This doesn't really solve the issue. 1. From the component we're on, if the user is logged in, then the correct workflow is to redirect to the location picker. This...

It seems then like this belongs more readily in the patient chart then, rather than the styleguide, more exactly, in the patient-common-lib.

> What do you think? I'm on-board. I kind of dislike "refactor" anyway, since "refactoring" can describe both changing things in a way that doesn't affect the API and changing...

This PR has way too many changes _not_ related to the Login page. Can we please remove those changes from this PR completely? PRs that are larger than they need...

FWIW, I'm not merging this for now to unblock #2506, which is, I think, slightly more critical

> it can't find amylase in the results viewer. Would you expect to see it under All orderable tests? Yes. It's in the TestsOrderability_v1 concept set which is a subset...

Although it does appear that not all tests were correctly loaded (48 here vs 300ish in OCL):

@donaldkibet The results viewer could handle radiology reports, but imaging would need its own view.