Ian
Ian
We'd like to get it in reasonably soon, but I'm not sure it's going to be enabled for, e.g., the dev3 / test3 / o3 stack. This is maybe something...
> My initial thought is that we probably shouldn't, which would mean restricting the external search to only the main search page. In general, querying an MPI is a registration...
> @ibacher, do you think we could add an attribute or tag to the patient [resource](https://github.com/openmrs/openmrs-esm-patient-management/pull/1313/files#diff-815ba10fcc983ee4592625a7ddaccc43fe379f506529e3099a1b2121f404a46cR16) to enable conditional UI rendering, instead of relying on route parameters? Say more...
@donaldkibet It's basically what Dennis said. We just need to ensure that we're not breaking search in other contexts. We may need to separate the "MPI search" out into it's...
For: 1. A better solution is just `window.location.pathname === `${getOpenmrsSpaBase()}search` 2. `try... catch` around hooks is not a pattern I'd want to encourage using. I think the better solution here...
Re: 2 something like: ```ts export const useSearchParams() { const [searchParams, setSearchParams] = useState(new URLSearchParams(window.location.search)); useEffect(() => { const updateSearchParams = () => setSearchParams(new URLSearchParams(window.location.search)); window.addEventListener('popstate', updateSearchParams); return () =>...
Thanks @EDSONZ-WASSWA. This LGTM. @chibongho I'm not sure if this is going to be the right way to handle things with Workspaces v2?
This option needs to be behind some kind of configuration. I don't think it should be enabled by default. I'm also slightly suspicious that embedding this in a frontend module...
@FelixKiprotich350 If I had exact thoughts on how this kind of feature should work, I would've included them. That's why I think we need a community discussion on Talk, because...
> I have tested a scenario when both are set and it's working as expected. Concept Numeric values are evaluated first then concept reference range values. This may be an...