Ian

Results 222 comments of Ian

@dicksonmulli I'm thinking about the scenario where we already have a reference range defined on the ConceptNumeric, but then also have a series of the new ConceptReferenceRange classes defined for...

Well, I think as long as we ignore the ConceptNumeric range if any `ConceptReferenceRange` evaluates to `true` (i.e., we assume that those reference ranges are correct), then we avoid any...

@icrc-loliveira Are you able to address the comments I made above?

@dkayiwa Not really, but I suggested that @wikumChamith might try something similar to the code I explained [here](https://github.com/openmrs/openmrs-core/pull/4710/files#r1719815597) to see if that fixes things. I added it to resolve a...

If we're going to support a version number, it should be a build-time constant, not set via config. Otherwise, I think the approach is fine.

@ManojLL Neither the ticket nor the PR give me any sense of why we'd want to merge this in. If anything, this seems likely to cause a regression since it...

Also, it doesn't look like this removes the whole submodule?

Ah ok! Do you mind if I convert this to a draft then? (I like the idea of doing this in stages!)

Let's keep it all in one PR, if that's alright...

I've fixed the tests so they work (according to me).