openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-6285: Update global_property Description Field to Use VARCHAR Instead of TEXT

Open ManojLL opened this issue 10 months ago • 2 comments

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-6285

Checklist: I completed these to help reviewers :)

  • [x] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [x] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [x] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

ManojLL avatar Mar 13 '25 05:03 ManojLL

Previous PR was closed by deleting the head repository.

ManojLL avatar Mar 13 '25 06:03 ManojLL

@ManojLL Neither the ticket nor the PR give me any sense of why we'd want to merge this in. If anything, this seems likely to cause a regression since it now introduces a character limit into a field without any current limits.

ibacher avatar Mar 27 '25 12:03 ibacher