openmrs-core
openmrs-core copied to clipboard
openmrs
TRUNK-5234:API Should Set the Concept for Non Coded Drug Orders
Ticket ID:https://issues.openmrs.org/browse/TRUNK-5234
Description
Detected Detected non coded drug orders
After ,i set the corresponding concept
Travis Failure , did it build successfully before committing ?
There are around 12 Failed Tests.
Coverage increased (+0.01%) to 60.607% when pulling 5d6d2ed6312cdafcaf8ad31d353e3d320d6a79ee on HerbertYiga:TRUNK-5234 into b0e875db015469fc859fab8a4cdf466c17a2e572 on openmrs:master.
@HerbertYiga The three things I'd like to see for this ticket are:
- Undoing the reformatting of the Javadoc
- The logic change I just suggested
- A unit test or tests to show that at least the behaviour added here works.
The main idea looks correct, though. Thanks for your work on this!
tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.
OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!
This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.
If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
hi @ibacher @dkayiwa does this look good enough now before its closed by GitHub actions bot?
Hello @HerbertYiga ,are you still working on this ticket?
@sherrif10 got some time to double check this soon
tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.
OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!
This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.
If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.
tl;dr closing this PR since it has not seen any activity in the last 6 months.
OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.
Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)