Wen Hui
Wen Hui
Honestly said, I think this idea is not necessary. 1. In Valkey (previous Redis), every command sent by client must go through the network twice -- client send the command,...
I have no objecttion to add this option. Becuase according to the SCAN, SSCAN, HSCAN and ZSCAN doc (https://redis.io/docs/latest/commands/scan/) , the return value is a two element multi-bulk reply, where...
> @hwware and @PingXie Your two votes are missing btw. Do you want to be explicit and add it to viktors comment. Voted, no objection for this.
@karthyuom When you compile valkey, try to run make SANITIZER=address, and run the test in your local to see if there are some memory leak. It is better run on...
Hey @madolson , I have updated the code as per the comments. Please take a look. Thank you.
> 44c0651a6ccff0dbb67f6219d4ee126754eb3a03 > 127.0.0.1:7383@17383,third,nodename=XXXX, shard-id=0a01a28e96ae3c335b97eab13ad8757807f2a375 > master - 0 1675886944444 2 connected > comments just to be sure i understand it correctly. i.e. it's just a label of free text,...
> I thought I commented on this, we decided to merge this change, #12166, first and then we will merge this. Hello @madolson , #12166 is merged and I have...
> Thanks @madolson for updating them. It looks good , Sorry I missed the @oranagra comments.
I am just curious do we need update these kind of function names? Or at lease so far, do we?